QQuick3DParticleSystem: don't pass const Connection to disconnect()
That overload will be deprecated, because the function modifies the
argument.
In this case, also move the contents of the m_connections map out of
the way ("consume loop"), so that the take() in
unRegisterParticleAffector() doesn't waste time finding the connection
in the map.
Amends 4838a84935cd9f2a4d74cdbf737b9c3da11aabfa (picked to 6.1).
Pick-to: 6.12 6.11 6.8
Task-number: QTBUG-144929
Change-Id: Iaf793cb67c0ab2376d97e2f61a7c81de860bc17a
Reviewed-by: Christian Strømme <christian.stromme@qt.io>