QSvgIconEngine: use covariant return in clone()
After verifying that this header is not installed, we can now fix
clone() to use a covariant return value, which is the idiomatic way,
because it allows Derived::clone() callers to depend on a Derived
static type instead of having to use an ugly (and eyebrow-raising)
cast.
If this was a public class, we couldn't do this change on Windows,
which name-mangles the return type. And, on all platforms, we would
have to check that the numeric pointer value doesn't change by this
change (see qtbase/da0f72ebb817bb9c92c7a183b281d8a4bf31a135 for
details). Thankfully, that's not an issue here.
Nothing seems to be calling this function (except through a
pointer-to-base), so no callers benefit from this, but we still do
it, as cut'n'paste will otherwise distribute this anti-pattern
elsewhere.
Amends the start of the public history.
Pick-to: 6.12 6.11 6.8
Change-Id: I0c864a3b479fe075e97faf9fab8b40bf05ec4089
Reviewed-by: Robert Löhning <robert.loehning@qt.io>