Mark the module as free of Q_FOREACH, except where it isn't
The density of Q_FOREACH uses is high here, too high for this author,
unfamiliar with this module, to tackle in a short amount of time. But
they're concentrated in just a few TUs, so pick a different strategy:
Mark the whole module with QT_NO_FOREACH, to prevent new uses from
creeping in, and whitelist the affected TUs by #undef'ing
QT_NO_FOREACH locally, at the top of each file. For TUs that are part
of a larger executable, this requires these files to be compiled
separately, so add them to NO_PCH_SOURCES (which implies
NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115807 to keep track of
this.
Ported one that was trivial and where whitelisting of the file with a
single Q_FOREACH would have been more work than directly fixing it.
Task-number: QTBUG-115807
Change-Id: I2fa6c740e35039baf34115af7d69d6c420e4de10
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
| commit | a84bf68892e93450e8c4ab1a6b90ae843dc6af35 |
| parent | 0c45ec75d82b480bc9a83095b297738b79c8980c |
| author | Marc Mutz <marc.mutz@qt.io> |
| committer | Marc Mutz <marc.mutz@qt.io> |
| commit time | Fri, 18 Aug 2023 10:22:24 +0200 |
- M .cmake.conf
- M src/datavisualization/CMakeLists.txt
- M src/datavisualization/engine/abstract3dcontroller.cpp
- M src/datavisualization/engine/abstract3drenderer.cpp
- M src/datavisualization/engine/axisrendercache.cpp
- M src/datavisualization/engine/bars3dcontroller.cpp
- M src/datavisualization/engine/bars3drenderer.cpp
- M src/datavisualization/engine/q3dscatter.cpp
- M src/datavisualization/engine/q3dsurface.cpp
- M src/datavisualization/engine/scatter3dcontroller.cpp
- M src/datavisualization/engine/scatter3drenderer.cpp
- M src/datavisualization/engine/surface3dcontroller.cpp
- M src/datavisualization/engine/surface3drenderer.cpp
- M src/datavisualizationqml/CMakeLists.txt
- M src/datavisualizationqml/abstractdeclarative.cpp
- M src/datavisualizationqml/declarativetheme.cpp
- M tests/manual/barstest/CMakeLists.txt
- M tests/manual/barstest/chart.cpp
- M tests/manual/itemmodeltest/main.cpp
- M tests/manual/scattertest/CMakeLists.txt
- M tests/manual/scattertest/scatterchart.cpp
- M tests/manual/surfacetest/CMakeLists.txt
- M tests/manual/surfacetest/graphmodifier.cpp