QGrpcOperationContext: remove argument() instead of deprecating
Amends 94216252e9477da02e3c79e123f0a550e448f18c.
QGrpcOperationContext::argument() is only accessible to users who
implement the private and undocumented QAbstractGrpcChannel interface.
Since this interface is not part of the public API and intentionally
undocumented, any usage before already relies on unsupported internals.
Keeping argument() for compatibility would therefore only preserve API
stability for code that is already outside supported usage.
Additionally, the method is unnecessary and has been identified as a
source of unintended memory growth in long-running streaming
applications.
Given the very limited impact surface and the fact that affected users
already depend on private API, we remove the function outright instead
of deprecating it. Custom channel implementations must already be
adjusted due to the earlier source-incompatible QAbstractGrpcChannel
virtual signature changes, so deprecating argument() would not provide
meaningful compatibility for supported users.
The '#if 0' guard is kept purely as a record of the removal (the API
existed in a public header) and to leave an explicit trace of what
changed.
Found during the Qt 6.11 API review.
[ChangeLog][Potentially Source-Incompatible Changes]
Removed QGrpcOperationContext::argument() in favor of the abstract RPC
interface. The class is only reachable through this interface, which is
undocumented and treated as private API.
Pick-to: 6.11
Fixes: QTBUG-144204
Change-Id: I2c58b454199fa47833cfaa32c555ace3c779aadb
Reviewed-by: Marc Mutz <marc.mutz@qt.io>