QGraphicsSvgItem: de-inline dtor
Destructors of polymorphic classes should be defined out-of-line, even
if empty, to avoid -Wweak-vtable and all the bad side effects that
weak vtables entail.
Unfortunately, this wasn't done for QGraphicsSvgItem, a public,
polymorphic class. Since its destructor was inline, we can't add code
to it, even when making it out-of-line, because old code will not
necessarily call the dtor from the vtable, but may have de-virtualized
the call (e.g. if the object was created on the stack in, say,
main()). Add a comment to that effect in the out-of-line body of the
function.
We can't pick this back to released branches, since it creates a new
symbol, breaking forward BC.
Amends the start of the public history.
Task-number: QTBUG-45582
Pick-to: 6.12
Change-Id: I1061f559b4a7df356008aaec13a737a1d797d0b8
Reviewed-by: Robert Löhning <robert.loehning@qt.io>