Improve detection of animation keyframe schema
The parser would determine to use old- or new-style keyframe schema
based on the version number present in the file. However, this has
proved to be unreliable: it is not uncommon to encounter files in the
wild with misleading or missing version numbers. Such files would
typically fail to render at all.
Instead, we base the detection on the presence of a data value ("s")
in the final keyframe, as that is all that is needed for new-style
parsing.
The effective change is the one-line setting of schemaChanged in
qlottieproperty_p.h. All the rest is just removing the handling of
the file version number info, as that is no longer needed.
Change-Id: Iad1a2441df347e0ec700ecd66bddef5ab83f36d3
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
| commit | 82cf47e018dd382a1c19574cb5da6b9aafb9ed87 |
| parent | f18f5f9fa868d02b6e646f507c5e432c0bc1356a |
| author | Eirik Aavitsland <eirik.aavitsland@qt.io> |
| committer | Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> |
| commit time | Tue, 27 May 2025 10:34:17 +0200 |
- M src/lottie/qlottiebase_p.h
- M src/lottie/qlottiebasictransform.cpp
- M src/lottie/qlottiebasictransform_p.h
- M src/lottie/qlottieellipse.cpp
- M src/lottie/qlottieellipse_p.h
- M src/lottie/qlottiefill.cpp
- M src/lottie/qlottiefill_p.h
- M src/lottie/qlottiefilleffect.cpp
- M src/lottie/qlottiefilleffect_p.h
- M src/lottie/qlottieflatlayers.cpp
- M src/lottie/qlottieflatlayers_p.h
- M src/lottie/qlottiefreeformshape.cpp
- M src/lottie/qlottiefreeformshape_p.h
- M src/lottie/qlottiegfill.cpp
- M src/lottie/qlottiegfill_p.h
- M src/lottie/qlottiegroup.cpp
- M src/lottie/qlottiegroup_p.h
- M src/lottie/qlottieimage.cpp
- M src/lottie/qlottieimage_p.h
- M src/lottie/qlottielayer.cpp
- M src/lottie/qlottielayer_p.h
- M src/lottie/qlottiepolystar.cpp
- M src/lottie/qlottiepolystar_p.h
- M src/lottie/qlottieprecomplayer.cpp
- M src/lottie/qlottieprecomplayer_p.h
- M src/lottie/qlottieproperty_p.h
- M src/lottie/qlottierect.cpp
- M src/lottie/qlottierect_p.h
- M src/lottie/qlottierepeater.cpp
- M src/lottie/qlottierepeater_p.h
- M src/lottie/qlottierepeatertransform.cpp
- M src/lottie/qlottierepeatertransform_p.h
- M src/lottie/qlottieroot.cpp
- M src/lottie/qlottieroot_p.h
- M src/lottie/qlottieround.cpp
- M src/lottie/qlottieround_p.h
- M src/lottie/qlottieshape.cpp
- M src/lottie/qlottieshape_p.h
- M src/lottie/qlottieshapelayer.cpp
- M src/lottie/qlottieshapelayer_p.h
- M src/lottie/qlottieshapetransform.cpp
- M src/lottie/qlottieshapetransform_p.h
- M src/lottie/qlottiespatialproperty_p.h
- M src/lottie/qlottiestroke.cpp
- M src/lottie/qlottiestroke_p.h
- M src/lottie/qlottietrimpath.cpp
- M src/lottie/qlottietrimpath_p.h
- M src/lottie/renderer/qbatchrenderer.cpp
- M src/lottie/renderer/qbatchrenderer_p.h
- M tests/auto/lottie/shape/ellipse/tst_lottieellipse.cpp
- M tests/auto/lottie/shape/fill/tst_lottiefill.cpp
- M tests/auto/lottie/shape/path/tst_lottiepath.cpp
- M tests/auto/lottie/shape/rect/tst_lottierect.cpp
- M tests/auto/lottie/shape/repeater/tst_lottierepeater.cpp
- M tests/auto/lottie/shape/repeatertransform/tst_lottierepeatertransform.cpp
- M tests/auto/lottie/shape/shapelayer/tst_lottieshapelayer.cpp
- M tests/auto/lottie/shape/shapetransform/tst_lottieshapetransform.cpp
- M tests/auto/lottie/shape/stroke/tst_lottiestroke.cpp
- M tests/auto/lottie/shape/transform/tst_lottiebasictransform.cpp
- M tests/auto/lottie/shape/trimpath/tst_lottietrimpath.cpp
- M tests/manual/featcheck/main.cpp