QWindowCapture: Never capture drop shadowing during window-capture
The ScreenCaptureKit backend was originally written to use the default
setting as to whether or not to capture drop shadows when capturing
windows. The platform default is to capture drop shadows. This was a
poor decision as including the drop shadow means the returned
QVideoFrame will have slightly larger dimensions than the window being
captured.
Other platforms tend not to capture drop shadows under this
situation. This patch makes is follow suit for the ScreenCaptureKit
backend.
As a drive-by, we start documenting in QPlatformSurfaceCapture the
intended behavior.
Pick-to: 6.12
Change-Id: I5d9bcff82383b51fe7f321c647d7606da5e2424d
Reviewed-by: Tim Blechmann <tim.blechmann@qt.io>
| commit | 79e00e9c06a76d22457c49631e319e4e22e0d99c |
| parent | 494f4ef402c867939ac34e092ce652c09ee221df |
| author | Nils Petter Skålerud <nils.petter.skalerud@qt.io> |
| committer | Nils Petter Skålerud <nils.petter.skalerud@qt.io> |
| commit time | Tue, 15 Sep 2026 08:12:23 +0000 |
- M src/multimedia/platform/qplatformsurfacecapture.cpp
- M src/multimedia/platform/qplatformsurfacecapture_p.h
- M src/multimedia/recording/qwindowcapture.cpp
- M src/multimedia/recording/qwindowcapture_p.h
- M src/plugins/multimedia/ffmpeg/darwin/qmacscreencapturekit.mm
- M src/plugins/multimedia/ffmpeg/darwin/qmacscreencapturekit_p.h
- M src/plugins/multimedia/ffmpeg/darwin/qsckscreencapture.mm
- M src/plugins/multimedia/ffmpeg/darwin/qsckwindowcapture.mm
- M tests/auto/integration/qwindowcapturebackend/fixture.cpp