QHttpServerRequestFilter: unexport non-polymorphic class
Non-polymorphic classes shouldn't be exported wholesale, as that can
cause many BC issues. Even though this particular class is not part of
BC constraints, unexporting the class prevents exporting a private
function taking QHash::iterator.
Export only the public out-of-line functions instead.
As drive-bys:
- drop the default ctor; the compiler can write it for us, and there's
no reason for it to be inline
- pass QHostAddress by cref, not by value. The class is implicilty
shared, so expensive to copy, in particular not trivially copiable,
so should be passed by reference; these functions are also not sinks
for the argument, so that exceptional use-case also doesn't apply.
- make the isRequestAllowed() function const (the other isX() functions
can't be, as they modify the ipInfo members)
- remove top-level const from function parameters
Amends 2d9e98680087c91db35f069e9cdbd31ddc50b5d5 and
c43b2f7a84ca1141b4d7d323d8b6cac7c75aa7e5.
Pick-to: 6.10 6.9
Change-Id: If239bbacaea3f8ac82825ff530b2821e331fb101
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>