Avoid double lookup in QQuick3DParticleSystem::unRegisterParticleAffector()
The old code first used the index operator on m_connections,
disconnect()ing its result (first lookup) and then remove()d the item
from the same container (second lookup).
Worse, if the key is not in the map, the first lookup will even create
the node, just for the remove() to remove it again.
Fix by using take(), which performs one lookup instead of two, and
won't create a node if not found (but crucially returns the same
Connection (a default-constructed one) in the case where the key
wasn't found).
Amends 4838a84935cd9f2a4d74cdbf737b9c3da11aabfa (picked to 6.1).
Pick-to: 6.12 6.11 6.8
Change-Id: Ic20f3f3c093a82cdff004c606f30c7b991b255a0
Reviewed-by: Christian Strømme <christian.stromme@qt.io>