Fix qmlsingletonthemetest leaking into CTest and its flaky assertions
tests/manual/qmlsingletonthemetest/ was added by a previous commit
("Add singleton theme autotest as a manual test", QTBUG-142814)
specifically to move a flaky QML theme test out of CI. The intent was
right, but its CMakeLists.txt never adopted Qt's manual-test
convention: it hand-rolled its own project()/enable_testing()/
qt_add_executable()/add_test() instead of using
qt_internal_add_manual_test(), which is the only mechanism that
actually suppresses CTest registration (every other tests/manual/*
directory uses it). As a result the test kept running under ctest
despite living under tests/manual/.
Also fix the underlying flaky pixel-comparison assertions in
tst_singletontheme.qml that the original commit was trying to escape:
- Remove measureFps: true from all graph declarations. It forces
continuous rendering for no benefit here (currentFps is never read),
and it defeats waitForRendering() as a reliable "my change is now
rendered" synchronization point.
- Relax the strict backimage.equals(origimage) whole-image bit-exact
checks down to the same pixel-sample comparison already used by the
"afterimage" checks. Antialiased rendering isn't guaranteed
bit-identical across two separate render passes, and the adjacent
compare() calls on theme properties already prove the state was
correctly reverted.
- Add an extra settle waitForRendering() before baselining freshly
created graphs in the "created and modified" test cases, since a
single wait after top.createGraphs() isn't enough to guarantee the
very first rendered frame is representative.
Verified with 6 consecutive full runs of the test binary directly
(25 passed, 0 failed each time), and confirmed `ctest -N` no longer
lists the test.
Pick-to: 6.12 6.11
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Change-Id: I9c324a624b6019eb044ae41ef093cffe9e469073
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>